@/climatemappedafrica Hero page map colour codes #993
Merged
+202
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Made Map visible on mobile
koechkevin
changed the title
|
💯 @koechkevin . How does hovering look like? |
@kilemensi I retained the hover colour as is on PesaYetu and location name appears next to Legend/Map Key |
🤔 ... If a region already has that color, I believe it won't make any difference @koechkevin ... Try setting the color to |
|
Looks good @koechkevin
3. Can we remove the **right** `margin`/`padding` on the map so that everything aligns nicely to the right from top of the page to bottom?
|
|
If my comments above have been addressed @koechkevin, don't wait for my approval if others are happy with the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per the feedback given during the demo, it is a requirement that all maps on Climatemapped Africa be colour-coded to match the explore page. In the words of Eric Climatemapped mirrors Pesa Yetu, the designs don't need to be exactly the same but Climatemapped should be an improvement of PesaYetu features.
This PR
Fixes #992
Type of change
Please delete options that are not relevant.
Screenshots
Checklist: